search

biolab / orange3-timeseries

🍊 :chart_with_upwards_trend: Orange add-on for analyzing, visualizing, manipulating, and forecasting time series data.
Other
62 stars 40 forks source link

Cumsum in Moving transform weird error: wrong results for 1st, 2nd, 4th and 5th column selected #265

Open wvdvegte opened 9 months ago

wvdvegte commented 9 months ago
Timeseries version

0.6.1

Orange version

3.36.3

Expected behavior

When applying Moving Transform to compute cumulative sums for one or more columns, the cumulative sum up till each row is computed correctly

Actual behavior

The cumulative sum is computed correctly for third column for which cumsum was checked, and also for the 6th, 7th, 8th and so on. For the 1st, 2nd, 4th and 5th column, incorrect results are provided.

Steps to reproduce the behavior

See attached workflow

Additional info (worksheets, data, screenshots, ...)

moving transform bug.ows.zip

ajdapretnar commented 8 months ago

This works as expected. Your output is "Keep original data", where on hover reveal the original data is kept, except for the N-1 (where N is window width). If you select "Include leading instances", you will see the aggregation is correct.

Let me know if the issue was solved.

wvdvegte commented 8 months ago

Thanks, @ajdapretnar - I see now how it is supposed to work. But "Keep original data" is misleading because the leading instances aren't kept (which are also "original data"). Suggestion: name the options "discard original data", "keep original data without leading instances" and "keep all original data" (or "keep original data with leading instances"). I would also reverse order in which the options are listed - the discard option seems less useful.