search

biomejs / biome-vscode

Biome extension for Visual Studio Code and VSCodium
https://marketplace.visualstudio.com/items?itemName=biomejs.biome
Apache License 2.0
237 stars 32 forks source link

🐛 Cannot find installed biome binary #337

Closed slhck closed 2 months ago

slhck commented 2 months ago

VS Code version

1.91.1

Extension version

v2024.8.301002

Biome version

1.8.3

Operating system

Description

SCR-20240909-jquh SCR-20240909-jqvm

Steps to reproduce

I simply added this:

yarn add --dev @biomejs/biome
npx biome init

I also installed the prerelease version of this extension.

Expected behavior

Biome binary from node modules should be found.

Does this issue occur when using the CLI directly?

Not sure / Not applicable

Link to a minimal reproduction

No response

Logs

2024-09-09 10:31:51.668 [info] Biome extension activated
2024-09-09 10:32:54.370 [error] Failed to start Biome extension
2024-09-09 10:32:54.370 [info] Biome extension started
2024-09-09 10:32:54.370 [info] User-facing commands registered
2024-09-09 10:32:54.370 [info] Started listening for lockfile changes
2024-09-09 10:32:54.370 [info] Started listening for configuration changes
2024-09-09 10:32:54.370 [info] Started listening for active text editor changes
2024-09-09 10:32:57.702 [info] 

2024-09-09 10:32:57.702 [info] Biome extension activated
slhck commented 2 months ago

PS: This works when using the stable version of the extension.

nhedger commented 2 months ago

There was an issue where the extension attempted to create a global session before creating a project session. If that failed for some reason, the rest wouldn't work. I believe 899efe17d31f7dc9866d9bb8ace13b7d64d03318 fixes that. Would you mind trying the latest pre-release (v2024.9.91939)?

I'll close in the meantime, but feel free to circle back if it does not fix the issue.

slhck commented 2 months ago

This seems to work, thanks!