Open tylerlaprade opened 2 months ago
ematipico
commented
2 months ago Thank you for the report, can you provide a reproduction?
To create a reproduction, you can use our new CLI tool, which should help you to create a very quick repository with what you need: npm create @biomejs/biome-reproduction
tylerlaprade
commented
2 months ago Hmm, I'm not able to repro even in my main project today. I wonder if it's because I changed my biome.projects setting.
EthanPintoA
commented
1 month ago I encountered a similar issue; however, it only causes some inconvenience when using the Biome extension for the first time.
Steps to Reproduce:
settings.json: "[jsonc]": { "editor.defaultFormatter": "biomejs.biome" }.settings.json, triggering an alert/popup/dialog that states Biome cannot format JSONC files.Although this displays as a popup instead of a notification, I believe it's related based on logs provided in this issue, as they suggest that the Biome extension fails to start due to a missing binary.
Instead of stopping, it might be more helpful if a notification could inform users that the binary or package is missing when they attempt to format, rather than just at start-up.
nhedger
commented
1 month ago As far as I know this isn't possible because the LSP session needs to have been started for Biome to be registered as a formater.
EthanPintoA
commented
1 month ago I just encountered another similar issue.
When I open my settings.json from my command palette, specifically using "Preferences: Open User Settings (JSON)", Biome on the Status Bar says, "The current file is not supported or ignored by Biome".
This also happens with files opened using "Preferences: Open Workspace Settings (JSON)". However, Biome works fine when using "Preferences: Open Workspace Settings (JSON)", "File: Open File...", and most other methods.
I'm on Windows if that helps.
nhedger
commented
12 hours ago @tylerlaprade JSONC is supported. You see this message because the extension fails to start the LSP session, which means the formatter doesn't get registered.
You should be able to troubleshoot why by setting the logging level of VS Code to Debug using the Developer: Set log level... command.
@EthanPintoA The issue you're experiencing seems unrelated; please open another issue if you're still experiencing the problem.
VS Code version
1.93.1
Extension version
v2024.9.200949 (pre-release)
Biome version
♺
Operating system
Description
Steps to reproduce
Open
settings.jsonthat has comments on some linesExpected behavior
The extension should not complain about "JSON with Comments"
Does this issue occur when using the CLI directly?
No
Link to a minimal reproduction
No response
Logs