biomejs / biome

A toolchain for web projects, aimed to provide functionalities to maintain them. Biome offers formatter and linter, usable via CLI and LSP.
https://biomejs.dev
Apache License 2.0
15.6k stars 486 forks source link

fix(js_semantic): scope for TsDeclarationModule #4580

Closed Conaclos closed 1 week ago

Conaclos commented 1 week ago

Summary

While I was testing https://github.com/biomejs/biome/pull/4579, I detected a bug introduced by https://github.com/biomejs/biome/pull/4546

As usual, we often forget to update the related methods when we push a new scope.

Test Plan

I manually tested the change. Unfortunately, our test infra doesn't handle .d.ts files

github-actions[bot] commented 1 week ago

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48595 48595 0
Passed 47403 47403 0
Failed 1192 1192 0
Panics 0 0 0
Coverage 97.55% 97.55% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6586 6586 0
Passed 2208 2208 0
Failed 4378 4378 0
Panics 0 0 0
Coverage 33.53% 33.53% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 608 608 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.41% 89.41% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18618 18618 0
Passed 14273 14273 0
Failed 4345 4345 0
Panics 0 0 0
Coverage 76.66% 76.66% 0.00%