search

birarda / logan

ruby gem to communicate with new Basecamp API
MIT License
16 stars 19 forks source link

Made some project attributes accessible #2

Closed jrodrigosm closed 10 years ago

jrodrigosm commented 10 years ago

Hi, I thought it would be nice to have access to some of the project's attributes (description, updated_at and archived) - at least I need that access for my project, I thought other people might need it too.

[This is my first pull request ever, I'm new at this, I hope I did everything right]

birarda commented 10 years ago

This looks great @jrodrigosm - can you run me through the changes to the Gemfile? Just not sure why they are also required.

jrodrigosm commented 10 years ago

Mmm, I'm afraid that's my mistake ... I run bundle update, and I accidentally committed a new Gemfile.lock with newer gem versions. But I did not test if those versions run correctly.

I don't know what's the usual thing to do in these cases. Feel free to reject my pull request. In that case very likely I will submit a new one in a few days, with some extra additions. And I will make sure not to commit unintended changes. Sorry about that.

birarda commented 10 years ago

No problem at all! I'm happy to take the existing pull request without those Gemfile changes if you want to do that now (you could revert the gemfile changes and push that and this pull request would be automatically updated). If you'd rather submit another one in a couple of days with more changes that's more than okay too. Once your changes are in I'll go ahead and release a new version of the gem.

jrodrigosm commented 10 years ago

I'd rather send you something more complete then, so that whenever you update the gem, it includes more features. Also, given that I'm still learning git, it's way easier for me to delete the branch and start again than to figure out how to exclude the Gemfile from the commit.

So please ignore this pull request. I will send you a new one. Thanks for your understanding.

birarda commented 10 years ago

Sure thing. Thanks for contributing! Let me know if you need any git or Github guidance and I would be happy to oblige.