search

bishopmatthew / HackerNews

An open source Hacker News client for Android.
230 stars 61 forks source link

Fix overlapping text displayed in SearchActivity #74

Closed anselina closed 10 years ago

anselina commented 10 years ago

Searching any text would display "No results found" and "Loading..." on top of each other, until the search results loaded. This is a minor fix, adding an additional check to make sure that the "no results" text is hidden if the search results are currently loading.

anselina commented 10 years ago

Sorry, forgot to include a screenshot and a few details! The bug can be reproduced like so: 1) From the main activity, click on the action overflow button on the top-right corner. 2) Type in some text in the "Search" field. 3) Click on the search button/icon. screenshot_2014-05-30-20-51-19-2

bishopmatthew commented 10 years ago

Thanks for reminding me to merge this, looks good. I appreciate the help!