search

bishopmatthew / HackerNews

An open source Hacker News client for Android.
230 stars 61 forks source link

Comments show as deleted #94

Closed Everlag closed 8 years ago

Everlag commented 8 years ago

When opening a thread, all comments appear in what seem to be the correct place but have content and author set to 'deleted'.

This happens on both my Nexus 4 and Oneplus 3.

seldonPlan commented 8 years ago

I can confirm, this is happening on my Nexus 6 as well

sjorsbranderhorst commented 8 years ago

I can confirm, same behaviour on samsung s5 mini.

zgkaos commented 8 years ago

I confirm the same is happening on Lg G3.

Everlag commented 8 years ago

Thanks for the confirmations, I believe HN's html changed.

This is probably where the issue happens, I'll play with the element selectors used in the app to see if there's a quick fix.

Everlag commented 8 years ago

Change looks like span to a div, PR #95

Everlag commented 8 years ago

Merged, thanks @bishopmatthew!

bishopmatthew commented 8 years ago

Rolling it out to the store now.

Thanks @Everlag