search

bisq-network / bisq-pricenode

GNU General Public License v3.0
5 stars 12 forks source link

Fix tests. QuoineTest removed. #14

Closed ghost closed 1 year ago

ghost commented 1 year ago

A recent change broke the tests. The Quoine provider has been obsoleted, test removed.

ghost commented 1 year ago

@Emzy, in the production pricenode, Binance API is down / provider is dead. The Binance test fails for the same reason. Do we want to remove the Binance provider?

Emzy commented 1 year ago

@Emzy, in the production pricenode, Binance API is down / provider is dead. The Binance test fails for the same reason. Do we want to remove the Binance provider?

It's a major exchange and AFAIK has fiat on/off-ramps. I think it would be very good to have a price feed from there. Could it be that the API changed?

Emzy commented 1 year ago

Looks like Binance works on my pricenode. So, it's not a problem in the code.

ghost commented 1 year ago

My mistake, was not running the pricenode correctly. This PR is ready for review / merge.

Emzy commented 1 year ago

Tested ACK No errors at the tests and it's running fine on my pricenode.

rodvar commented 1 year ago

Probably be good to merge this one before my PR (https://github.com/bisq-network/bisq-pricenode/pull/15) and I can rebase it and remove the temporary fixes that I've used to be able to keep going

alvasw commented 1 year ago

@alejandrogarcia83 @gabernard We need this PR to build the pricenode. Please merge this PR!