Bisq2 - Android & Java code unification

bisq-network / proposals

@bisq-network improvement proposals

https://bisq.wiki/Proposals

43 stars 16 forks source link

Bisq2 - Android & Java code unification #399

Closed niyid closed 1 year ago

niyid commented 1 year ago

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

I had to make changes to several sub-projects (common, tor and persistence) to the original Java project for a successful Android build.

Currently all the other issues are resolved and should work as well for Java, except for item 2 - the matter of java.lang.management.ManagementFactory. The idea is to find a O/S neutral way to start tor (or any process) that works on Both Android and Java.

Once this pending issue is resolved, there will be no need for code fragmentation where different versions of common, tor and persistence are maintained for Java and Android. Rather a unified code will be maintained.

Please find attached the issue list.

javaVSandroid

niyid commented 1 year ago

Tor Android seems to be the best method for starting Tor on Android that I could find. But this will not be compatible with Java.

If there are any suggestions that will work for both Java and Android, they will be appreciated.

Of course if the unification will not work,we should proceed with maintaining bisq2-android as a fork.

pazza83 commented 1 year ago

Hi @niyid thanks for creating this proposal.

Have you have a look at the proposal guidelines: https://bisq.wiki/Proposals ?

I am not understanding what you are proposing.

I am also not sure what you are looking to seek consensus on.

niyid commented 1 year ago

@pazza83

Apologies if you find it difficult to understand the thrust of this proposal.

I am working on a Bisq2 Android version.
I had to make changes to several core projects as listed in the initial post because of limitations in Android.
Some of these changes will work OK in Java; but the most stubborn issue is Tor.
Since Bisq2 is still in its infancy, there is a chance to prevent fragmentation (forking) and maintain same code for Java and Android.

HenrikJannsen commented 1 year ago

@niyid I think you should just continue as a fork. The current devs do not have the resources to support this work at the current state. Also the proposal area is not the right place for such discussions.

pazza83 commented 1 year ago

Closing due to lack of discussion

niyid commented 1 year ago

I suppose there is an alternative pathway to building for Android?

It is my opinion that this is the right first step to prepare for an Android app.

Without the protocol being the same for all devices (PC/Mobile/Handheld), it will be impossible to build for other devices.

niyid commented 1 year ago

The Push Request for documentation purposes