bitExpert / phpstan-magento

Magento specific extension for PHPStan
MIT License
134 stars 24 forks source link

Compatibility with PHPstan 1.10.x #294

Closed hostep closed 1 year ago

hostep commented 1 year ago

Hi there

PHPstan 1.10.x versions are being released since a few days: https://github.com/phpstan/phpstan/releases

However, this module has a pretty strict constraint on it: ~1.9.2 which prevents us from upgrading to them.

Can't we open up the constraint a bit more, so that newer versions of phpstan (which are supposed to be backwards compatible) can also be installed, so maybe: ^1.9.2 ?

Thanks!

shochdoerfer commented 1 year ago

I added the strict constraint last year on purpose. I added it after the issues with the autoloader changes in PHPStan core happened which broke this extension.

In other news: Will be working on updating the dependencies in the next few days. Be a bit patient :)

hostep commented 1 year ago

Okay, perfect, no worries, take your time 😄

shochdoerfer commented 1 year ago

Here you go: https://github.com/bitExpert/phpstan-magento/releases/tag/v0.29.0

Let me know if this breaks anything :)

hostep commented 1 year ago

Many thanks! Just tested it out quickly and seems to work fine on some small modules.