search

bitExpert / phpstan-magento

Magento specific extension for PHPStan
MIT License
134 stars 24 forks source link

Version 0.30.0 fails with errors about unexpected items in parameters #301

Closed hostep closed 1 year ago

hostep commented 1 year ago

Hi there

Our pipelines (that always pull in the latest version of this package) started failing with the release of version 0.30.0:

$ vendor/bin/phpstan analyse
Note: Using configuration file phpstan.neon.
Invalid configuration:
Unexpected item 'parameters › extdn'.
Invalid configuration:
Unexpected item 'parameters › magento › checkResourceModelsUsedDirectly'.

Any idea what these errors are about @shochdoerfer ?

shochdoerfer commented 1 year ago

Huh, that was fast and unexpected ;(

I added new parameters to the extension to configure new rules. Did not expect to break anything ;( Can you post your phpstan.neon file? In the meanwhile, I'll do some more checks. Sorry.

shochdoerfer commented 1 year ago

Ah my bad, I see the problem. I wonder why our CI pipeline did not fail. Let me fix this quickly.

shochdoerfer commented 1 year ago

@hostep should be fixed with 0.30.1 - let me know if there are some more issues

hostep commented 1 year ago

Yes confirmed, it's fixed now. Thanks for the quick action! 🙂