search

bitcoin-core / gui

Bitcoin Core GUI staging repository
https://github.com/bitcoin/bitcoin
MIT License
602 stars 266 forks source link

Issues with new create wallet dialogue #151

Open Rspigler opened 3 years ago

Rspigler commented 3 years ago

As commented here (https://github.com/bitcoin-core/gui/pull/96#issuecomment-727259580)

Encrypt Wallet: "Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice." This is incorrect. The wallet is not encrypted, only the private keys are.

Also, this inconsistency:

Checking Disable Private Keys checks Make Blank Wallet (and disables Encrypt Wallet). This is correct. Disable Private Keys should only be checked when Make Blank Wallet is also checked. However, there is a way to have Disable Private Keys checked without having Make Blank Wallet checked (which doesn't make sense).

Check Disable Private Keys, then uncheck the auto-check Make Blank Wallet. You are now left with the settings:

Disabled Encrypt Wallet, checked Disable Private Keys.

This is a setting that you can't enable yourself. (Checking Disable Private Keys also checks Make Blank Wallet normally).

To fix, unchecking the auto-enabled Make Blank Wallet should also uncheck Disable Private Keys and re-enable Encrypt Wallet.

hebasto commented 3 years ago

cc @achow101 @Sjors

hebasto commented 3 years ago

@Rspigler

Encrypt Wallet: "Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice." This is incorrect. The wallet is not encrypted, only the private keys are.

This wording seems ubiquitous:

Screenshot from 2021-03-05 03-21-59

Rspigler commented 3 years ago

Where is that screenshot from? Some wallets do encrypt the entire wallet. Bitcoin Core doesn't.

Compiling on master, I still see for the tooltip "Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice", which is incorrect. The wallet is not encrypted, the private keys are, which are two very different things https://github.com/bitcoin/bitcoin/issues/18085

There are also various text boxes after encrypting the wallet which are incorrect "You wallet is now encrypted" etc.

hebasto commented 3 years ago

@Rspigler

Where is that screenshot from?

The Bitcoin Core.

Create a wallet without encryption. then in menu go to "Settings" -> "Encrypt Wallet".

Rspigler commented 3 years ago

That should be changed as well then. For example, metadata is not encrypted.

maflcko commented 6 months ago

See also https://github.com/bitcoin-core/gui/pull/722#issuecomment-2124671596