bitcoin-core / gui

Bitcoin Core GUI staging repository
https://github.com/bitcoin/bitcoin
MIT License
603 stars 266 forks source link

test: Set organization name #803

Closed hebasto closed 8 months ago

hebasto commented 8 months ago

From Qt docs:

If QCoreApplication::setOrganizationName() and QCoreApplication::setApplicationName() has not been previously called, the QSettings object will not be able to read or write any settings, and status() will return AccessError.

Fixes https://github.com/bitcoin-core/gui/issues/799.

DrahtBot commented 8 months ago

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process. Type Reviewers
ACK pablomartin4btc
Stale ACK sipsorcery

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented 8 months ago

Friendly ping @ryanofsky @sipsorcery @furszy @jarolrod

sipsorcery commented 8 months ago

Building this PR with msvc and running test_bitcoin-qt.exe gives me:

...snip...
********* Start testing of OptionTests *********
Config: Using QtTest library 5.15.11, Qt 5.15.11 (x86_64-little_endian-llp64 static release build; by MSVC 2022), windows 11
PASS   : OptionTests::initTestCase()
PASS   : OptionTests::migrateSettings()
PASS   : OptionTests::integerGetArgBug()
PASS   : OptionTests::parametersInteraction()
PASS   : OptionTests::extractFilter()
PASS   : OptionTests::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 20ms
********* Finished testing of OptionTests *********
...snip...

Does that demonstrate the fix?

hebasto commented 8 months ago

Building this PR with msvc and running test_bitcoin-qt.exe gives me:

...snip...
********* Start testing of OptionTests *********
Config: Using QtTest library 5.15.11, Qt 5.15.11 (x86_64-little_endian-llp64 static release build; by MSVC 2022), windows 11
PASS   : OptionTests::initTestCase()
PASS   : OptionTests::migrateSettings()
PASS   : OptionTests::integerGetArgBug()
PASS   : OptionTests::parametersInteraction()
PASS   : OptionTests::extractFilter()
PASS   : OptionTests::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 20ms
********* Finished testing of OptionTests *********
...snip...

Does that demonstrate the fix?

Exactly.

sipsorcery commented 8 months ago

tACK 49cf63522e202caf326bad161ff6fa05d1076566.