Closed hebasto closed 8 months ago
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process. | Type | Reviewers |
---|---|---|
ACK | pablomartin4btc | |
Stale ACK | sipsorcery |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Friendly ping @ryanofsky @sipsorcery @furszy @jarolrod
Building this PR with msvc and running test_bitcoin-qt.exe
gives me:
...snip...
********* Start testing of OptionTests *********
Config: Using QtTest library 5.15.11, Qt 5.15.11 (x86_64-little_endian-llp64 static release build; by MSVC 2022), windows 11
PASS : OptionTests::initTestCase()
PASS : OptionTests::migrateSettings()
PASS : OptionTests::integerGetArgBug()
PASS : OptionTests::parametersInteraction()
PASS : OptionTests::extractFilter()
PASS : OptionTests::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 20ms
********* Finished testing of OptionTests *********
...snip...
Does that demonstrate the fix?
Building this PR with msvc and running
test_bitcoin-qt.exe
gives me:...snip... ********* Start testing of OptionTests ********* Config: Using QtTest library 5.15.11, Qt 5.15.11 (x86_64-little_endian-llp64 static release build; by MSVC 2022), windows 11 PASS : OptionTests::initTestCase() PASS : OptionTests::migrateSettings() PASS : OptionTests::integerGetArgBug() PASS : OptionTests::parametersInteraction() PASS : OptionTests::extractFilter() PASS : OptionTests::cleanupTestCase() Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 20ms ********* Finished testing of OptionTests ********* ...snip...
Does that demonstrate the fix?
Exactly.
tACK 49cf63522e202caf326bad161ff6fa05d1076566.
From Qt docs:
Fixes https://github.com/bitcoin-core/gui/issues/799.