search

bitcoin-sv / ts-sdk

Other
51 stars 13 forks source link

[fix] Compact SIgnatures Pubkey Recovery function precision. #63

Closed sirdeggen closed 6 months ago

sirdeggen commented 6 months ago

Thanks Zan from Rock Wallet / nChain team for the patch.

There were a few missing Mod N operations which meant some signatures recovered the incorrect pubkey.

ty-everett commented 6 months ago

It would be nice to see a test case for the old behavior, to make sure it doesn't get re-introduced in the future. If Zan has this available from when the issue was caught, it might be good to capture.

sirdeggen commented 6 months ago

For future reference, the change came from comparing the code with the BitcoinJ library in Java.