bitcoindevkit / bdk

A modern, lightweight, descriptor-based wallet library written in Rust!
Other
871 stars 312 forks source link

Fix docs for Wallet:create_tx when empty output vector #1717

Open notmandatory opened 2 weeks ago

notmandatory commented 2 weeks ago

"In Wallet::create_tx when the outputs vector of the transaction is empty, you have a comment "We have a drain_to address and the utxos we must spend (this happens, for example, when we RBF)" which seems misleading to me. If by "when we RBF" you mean what build_fee_bump does, then it's incorrect as build_fee_bump won't set params.drain_to."