Sqlite - allow persisting anchor without tx - Githubissues

bitcoindevkit / bdk

A modern, lightweight, descriptor-based wallet library written in Rust!

Other

871 stars 312 forks source link

Sqlite - allow persisting anchor without tx #1736

Closed evanlinjin closed 1 day ago

evanlinjin commented 1 week ago

Description

Previously, we may error when we insert an anchor where the txid being anchored has no corresponding tx.

closes #1712 replaces #961

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

New Features:

[ ] I've added tests for the new feature
[ ] I've added docs for the new feature

Bugfixes:

[ ] This pull request breaks the existing API
[x] I've added tests to reproduce the issue which are now passing
[x] I'm linking the issue being fixed by this PR

evanlinjin commented 1 week ago

@ValuedMammal feel free to take this one over. I'm assuming this will fix the problem, but needs tests.

notmandatory commented 1 week ago

Tests from #961 could be useful.

evanlinjin commented 3 days ago

@ValuedMammal I forced pushed to rebase on master.