search

bitcraze / crazyflie-simulation

MIT License
64 stars 27 forks source link

Run Webots sim from Python GUI client #43

Closed simondlevy closed 1 year ago

simondlevy commented 1 year ago

Now featuring @knmcguire's awesome PID controller!

knmcguire commented 1 year ago

hi! Let's perhaps talk battle plan first! I've started a discussion thread here: https://github.com/orgs/bitcraze/discussions/863

knmcguire commented 1 year ago

I think that, if we leave the cfclient out for now and only provide a stand alone socket script to this repo only, we can go ahead and merge this, and I'll make sure there are no conflicts with my upcoming draft PR. @simondlevy would you have time to do this or shall I look into that?

simondlevy commented 1 year ago

Given my relative inexperience with PRs and the Crazyflie project setup, I think it would make sense for you to look into that.

knmcguire commented 1 year ago

Hi! So I've pushed more changes to the PR. I do see that your PR is based on the main branch of your forked simulation repository so that means the changes are in there as well... Just be aware of that in case you use this repo for your own research, but you can create a new branch and revert the commits on that.

I also removed some changes done in the proto and environment files. We want to aim to keep these as close as possible to the Webots implementation.

Already a tip for PRs: it's always good to create PRs from branches and not the main 'trunk' :)

Anyway, let me know if this looks good! I think it is an good example that we can start from for the other changes we mentioned in discussions https://github.com/orgs/bitcraze/discussions/863