search

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL
bitemyapp.com
BSD 3-Clause "New" or "Revised" License
422 stars 118 forks source link

Support es 7 #266

Closed AlexeyRaga closed 3 years ago

AlexeyRaga commented 4 years ago

Changes

Note that one tests is currently disabled due to a bug that I have found in the ES itself: https://github.com/elastic/elasticsearch/issues/48670 The bug hits rather rare use case, and bloodhound is not at fault so I think it shouldn't be a show stopper for moving forward.

AlexeyRaga commented 4 years ago

@bitemyapp Sorry, I did not realise that Travis is using a different way of provisioning the ES and that there was an example project.

I have fixed them both and now the build is green, please have another look.

bitemyapp commented 4 years ago

@AlexeyRaga I'm interested in supporting this and updating Bloodhound to ES 7. I've asked @JoseD92 to combine his ES 7 update effort with what you've done. So even if we don't merge this specific PR in the end, it's likely the final PR will reflect the good work you've done here.

AlexeyRaga commented 4 years ago

@bitemyapp Where I can see these changes? We are currently maintaining our own fork of bloodhound and it would be useful to see what I missed and probably get these changes too until the official release is out.

AlexeyRaga commented 4 years ago

With @JoseD92 PR merged, what holds us back from having ES7 support in master and on Hackage?

rsoeldner commented 4 years ago

@bitemyapp @AlexeyRaga any update on this ?

teto commented 3 years ago

that would be awesome, as well as an update on katip-elasticsearch. I can help but would like some confirmation this works first.

bitemyapp commented 3 years ago

cc @wraithm

teto commented 3 years ago

I've tried to use this with katip-elasticsearch and this update breaks it. I wonder where it's best to break the interface bloohound vs katip (I don't know enough about either to have an opinion)

bitemyapp commented 3 years ago

cc @MichaelXavier https://github.com/bitemyapp/bloodhound/pull/266#issuecomment-717930767

ivanbakel commented 3 years ago

@wraithm I've addressed the style nits you raised.

It seems that the original author is no longer in a position to maintain this particular PR. If there are any other changes that need to be made, I am happy to have a go - but I will need to re-open this under a fork I control. (For example, it seems that the disabled test could be re-enabled).

wraithm commented 3 years ago

Great! Thanks. I'll get to this later today.

wraithm commented 3 years ago

@MichaelXavier Ping, do you have any opinions about katip-elasticsearch and this PR? I've reviewed this, and I'm pretty sure this is good to go.