bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!
BSD 3-Clause "New" or "Revised" License
370 stars 107 forks source link

Add `SqlSelect` instance for `:&` #268

Closed ivanbakel closed 3 years ago

ivanbakel commented 3 years ago

Fixes #267.

Before submitting your PR, check that you've:

After submitting your PR:

ivanbakel commented 3 years ago

Since we're adding an instance to a class we control, I think it's fine to make this a patch version.

It's your repo, but the PVP does specify that this should be a minor version bump.

parsonsmatt commented 3 years ago

I'm sorry, I was mistaken about that. I'll go ahead and merge-on-green and make that change myself.

Thanks so much for your contribution! 😄

ivanbakel commented 3 years ago

Since I had time, I've bumped the version to 3.5.2.

parsonsmatt commented 3 years ago

Thank you! I'll get this released today.