Message visibility toggle only turns messages off (doesn't actually toggle)

bitfocus / companion-module-getontime-ontime

MIT License

8 stars 5 forks source link

Message visibility toggle only turns messages off (doesn't actually toggle) #58

Closed lukestein closed 6 months ago

lukestein commented 6 months ago

The Toggle/On/Off visibility of message > Toggle action seems to only turn message visibility off rather than actually toggle it.

(The On and Off actions seem to work as expected)

Demo: https://github.com/bitfocus/companion-module-getontime-ontime/assets/44452336/f8f6b2c8-f875-4241-867b-25b8bb0f09f2

alex-Arc commented 6 months ago

Yes I see that as well Have you found other broken toggles?

lukestein commented 6 months ago

The only other two toggles (blackout timer and blinking timer) seem to work as expected!

I just quickly tried to test a bunch of the Companion actions (definitely didn't hit every option of every one), and all else seem to work as expected except I can't figure out where the "Lower" or "Public" messages get sent (probably user error, though)

alex-Arc commented 6 months ago

They have been removed from ontime and will also be gone from companion in the next release