search

bitmovin / libdash

MPEG-DASH Access Library - Official ISO/IEC MPEG-DASH Reference Implementation
https://bitmovin.com/
589 stars 169 forks source link

Fixing problem with Representation Base #43

Open jmunozpoveda opened 2 years ago

jmunozpoveda commented 2 years ago

There is a problem storing concrete objects and returning interfaces. Right way is store directly the interface in the class

jmunozpoveda commented 2 years ago

@msmole @schellkenig @slederer Could you take a look to this PR? I was trying to know if a Adaptation set had TrickModes. So I had to check GetRepresentations and then get GeSchemeIdUri, but accessing to this string I was getting a segmentation fault. The root cause is the explanied y my previous comment, IRepresentationBase has to store the interfaces instead of the explicit class and then casting to interface.

BTW: From Telefonica Team we have done another MR, one fixing the problem with Qt sample due to a old ffmpeg version, and another one fixing a problem in functionn BlockQueuePeekBytes. It would be great if you can merge/review this things.

BR, Julian

zenzi-deluxe commented 1 year ago

Hi @jmunozpoveda, thank you for opening this PR. Could you provide more information regarding the manifest you are using so that we can test it?