bitovi / documentjs

The sophisticated documentation engine
https://documentjs.com/
MIT License
598 stars 381 forks source link

Dynamically get available port for connect server #230

Closed rjgotten closed 6 years ago

rjgotten commented 8 years ago

Adds the get-port module to dev dependencies and uses it to dynamically get an available port for the connect server used by unit tests.

This avoid port-in-use errors and fixes #229

Also contains the necessary .gitattributes setting to work around #228

rjgotten commented 8 years ago

FYI; there's a problem with the Travis CI tests timing out. Looks like the default allotment of 2000ms is not enough for some of the async tests.

justinbmeyer commented 8 years ago

Thanks! I'll look into the timing issue.

m-mujica commented 6 years ago

Closing this in favor of #291, Thanks @rjgotten for the PR, I made the changes in a new PR since it was easier than merging master in.