search

bitovi / jquerypp

jQuery's missing utils and special events
http://jquerypp.com
MIT License
1.21k stars 160 forks source link

Fix JMVC 3.2 shims in `jquerypp/model/list` #104

Open asavoy opened 11 years ago

asavoy commented 11 years ago

We found that the jquerypp/model/list module contains some shims that maintain backwards-compatibility with JavascriptMVC 3.2 code. Unfortunately, the shims were broken because their "results" were unused.

We fixed these, and added tests to prove the failures, and cover the fixed usages.

This helps developers who are updating a project version from pre-3.3 - less code to have to fix.

asavoy commented 10 years ago

Would be great to get some feedback on this pull request! :)

It's fixing backwards compatibility for projects migrating from JavascriptMVC 3.2 - the code that is affected looks like it tries to achieve this, but just falls short.

amelon commented 10 years ago

project still alive?

alexisabril commented 10 years ago

Project's still alive, however this particular issue warrants a bit of discussion. jQuery++'s primary goal is to fill the gaps that jQuery itself has at the moment. However, due to our migration in JMVC, a few JMVC bits live in this project(model/list being one of them). Some of the discussion rests around how to migrate the MVC bits out of jQuery++, as only JMVC users utilize those pieces.

justinbmeyer commented 10 years ago

jQuery++ is alive, but we're no longer working on its backwards compatible shims.

Sent from my iPhone

On Jan 6, 2014, at 7:54 AM, Arnaud notifications@github.com wrote:

project still alive?

— Reply to this email directly or view it on GitHub.