various bugfixes and tests

bitpay / bitcore-p2p

Interface to the bitcoin P2P network for bitcore

MIT License

80 stars 276 forks source link

various bugfixes and tests #31

Closed maraoz closed 9 years ago

maraoz commented 9 years ago

fixes https://github.com/bitpay/bitcore/issues/1018
fixes https://github.com/bitpay/bitcore/issues/711
fixes ipv4/ipv6 parsing
adds inv/getdata integration tests
fix version and addr messages parsing/serialization
added preconditions to check parsing is correct
convert many Buffer members to more friendly types (objects, numbers, etc)
increase test coverage

maraoz commented 9 years ago

I'll fix coverage decrease first

coveralls commented 9 years ago

Coverage increased (+1.48%) to 91.92% when pulling c62409c4bcf2edb3c2acf9704a416efe26bd266c on maraoz:preconditions into 61754b267b24fc7f6f6f47f5cf3d235274e9c545 on bitpay:master.

eordano commented 9 years ago

LGTM

yemel commented 9 years ago

LGTM

maraoz commented 9 years ago

updated

coveralls commented 9 years ago

Coverage increased (+1.48%) to 91.92% when pulling e816c8254dee8ae4e832e643d6fa939462485c70 on maraoz:preconditions into 61754b267b24fc7f6f6f47f5cf3d235274e9c545 on bitpay:master.