search

bitpay / cordova-plugin-qrscanner

A fast, energy efficient, highly-configurable QR code scanner for Cordova apps and the browser.
MIT License
567 stars 773 forks source link

Who has the best Fork ? #385

Open nanolink opened 1 year ago

nanolink commented 1 year ago

Hi all. It is very unfortunate that this project has been abandoned. Is someone maintaining a good solid fork with support for both platforms (iOS & Android), which we can help with? Right now it seems everyone is forking and cooking their own fixes.

Joining forces would be the best roadmap.

jacobg commented 1 year ago

I put in a fair amount of work modernizing this project: https://github.com/jacobg/cordova-plugin-qrscanner/commits/modernize

rolinger commented 1 year ago

@jacobg - thanks for the work you have put into this. Two questions: is this Cordova 11 (Cordova-Android 11) compatible? And, why am I having a devil of a time trying to install it?

These are failing to find your fork: ionic cordova plugin add https://github.com/jacobg/cordova-plugin-qrscanner ionic cordova plugin add https://github.com/jacobg/cordova-plugin-qrscanner.git ionic cordova plugin add https://github.com/jacobg/cordova-plugin-qrscanner/

The link in your github.com fork shows it as: https://github.com/jacobg/cordova-plugin-qrscanner.git - but standard adding the plugin is failing with an error of: Error: no git binary found in $PATH

I then downloaded it and tried to install locally and got an error saying "MyApp" is not in the npm registry - implying its using the package.json from my project root versus the package.json from the unpacked plugin directory. Can't make heads or tails of this one.

jacobg commented 1 year ago

Hi @rolinger. Yes I'm using it on Cordova Android 11 and Cordova iOS 6.2. I'm using vanilla Cordova, not Ionic.

I don't remember exactly the cli call I used originally, but it shows in package.json as follows:

"cordova-plugin-qrscanner": "github:jacobg/cordova-plugin-qrscanner#modernize"

Note it's on the modernize branch, not main branch.

So you might try running:

ionic cordova plugin add github:jacobg/cordova-plugin-qrscanner#modernize
rolinger commented 1 year ago

@jacobg - thanks for getting back. I recommend you and @v1934 (https://github.com/v1934/cordova-plugin-qrscanner-11) collaborate on a new qrscanner together - you two seem to be the only ones who have kept up with keeping qrscanner alive. I think a merged project, a new qrscanner, would enhance both of your individual efforts. I wouldn't mind getting in on the action too as I have a vested interest in keeping this plugin alive.