bitpay / cordova-plugin-qrscanner

A fast, energy efficient, highly-configurable QR code scanner for Cordova apps and the browser.
MIT License
567 stars 773 forks source link

Android Cordova 11 build fails #397

Open rolinger opened 1 year ago

rolinger commented 1 year ago

Getting the following error:

I got this error on both master 3.0.1 and on a more recent fork cordova-plugin-qrscanner-11@3.0.3 (May 2022).

About 2 weeks ago I read that there was issue with Cordova 11 and that someone had created another fork for it but I can't recall where I read it or find the fork that fixes it. Can anyone post that link please?

rolinger commented 1 year ago

I got this resolved fixing the gradle script. In gradle 7.0 and higher certain methods have been replaced. Note that the compile, runtime, testCompile, and testRuntime configurations introduced by the Java plugin have been deprecated since Gradle 4.10 (Aug 27, 2018), and were finally removed in Gradle 7.0 (Apr 9, 2021).

The aforementioned configurations should be replaced by implementation, runtimeOnly, testImplementation, and testRuntimeOnly, respectively.

Thus changing the plugin src/android/qrscanner.gradle file fixed the install for me. So far, the plugin has loaded and seems to work fine now on Cordova11 (cordova-android11). Haven't tested iOS yet. Thats next after I rebuild my project for Cordova 11 on the Mac.

dependencies {
    //compile 'com.journeyapps:zxing-android-embedded:3.3.0'
    //compile 'com.android.support:appcompat-v7:23.1.0'
    implementation 'com.journeyapps:zxing-android-embedded:3.3.0'
    implementation 'com.android.support:appcompat-v7:23.1.0'
}
v1934 commented 1 year ago

I have released update 3.0.5 of the cordova-plugin-qrscanner-11 with merged pull requests that should fix both gradle compatiblity and update the xzing-android-embedded package to a higher version, which should apparently make scanning faster.

I have tested it on my project but it's still using cordova 10, please let me know if it works for you now when using cordova-plugin-qrscanner-11@3.0.5