search

bitrise-io / bitrise-steplib

New Bitrise StepLib
MIT License
158 stars 368 forks source link

firebase-app-distribution app_path resolved incorrectly #3108

Closed viktorasl closed 3 years ago

viktorasl commented 3 years ago

https://github.com/bitrise-io/bitrise-steplib/blob/f14d8a376551e2c7be19bfc09883a2dba1891171/steps/firebase-app-distribution/0.9.0/step.yml#L45

If i.e BITRISE_IPA_PATH is defined then this line produces:

app_path: /path/to/ipa||

and then next step that uses the app_path fails, because it contains two column characters at the end. Previous version 0.8.0 had one one column character at the end and somehow it did not bother other steps.

/cc @guness

I tried fixing it in steplib but could not find a way to inject some sort of script to resolve it as it was intended. Probably the best way is to do three separate variables and resolve in the step source.

guness commented 3 years ago

Good catch, and sorry for the trouble. You can continue using v0.8.0 until this is fixed. I will check this asap.

guness commented 3 years ago

should be fixed by #3111

guness commented 3 years ago

@viktorasl can we close the issue now? or someone else