Build starts immediately even when "Enable manual build approval option" is set

[mark-veenstra]

Hi,

We would like to approve builds on PR changes provided by forks. Therefore we enabled the option: "Enable manual build approval option". Like so:

But once a fork submits changes the build is started directly instead of the need of approval. See: https://app.bitrise.io/build/24506030a2a538d8#?tab=log

For now I made the trigger only to response to a specific source branch so forks can't start any builds at the moment.

Any idea?

Mark

[Roland-Bak]

Hey there @mark-veenstra 🙂

Could you please clarify if the build is started when a Pull Request is made, or when it has been accepted and has been merged into the target branch?

I think the root of the issue is that the 'Enable manual build approval option' is for Pull Requests, but merging into a branch counts as a Push regarding the Bitrise triggers.

[mark-veenstra]

Well what I am trying to accomplish with Bitrise and our opensource plugin is as follows:

Changes made with MR/PR not from a forked repository (which means changes applied through MR/PR from known authorized developers):

• Workflow on Bitrise should be triggered on MR/PR changes
• A known and authorized developer creates a MR/PR on GitLab. This MR/PR has a feature source branch and master as target branch.
• When this developer pushes changes to the source branch, the trigger of a changing MR/PR should trigger the workflow without any approvals

Changes made with MR/PR from a forked repository (which means changes applied through MR/PR from unknown developers with potential of stealing stuff):

• Workflow on Bitrise should be triggered on MR/PR changes (but needs approvals)
• An unknown developer creates a MR/PR on GitLab. This MR/PR has a feature source branch from forked repository and master as target branch.
• When this developer pushes changes to the forked source branch, the trigger of a changing MR/PR should trigger the workflow but with approvals to start the build.
• We can now investigate the source code and ones we validated it we can start the build manually by approving it.

Hope this makes it clear. If not I am happy to share more information.

[github-actions[bot]]

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

[github-actions[bot]]

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.