bitrise-steplib / steps-ionic-archive

MIT License
4 stars 22 forks source link

use capacitor for ionic archive #57

Open aabanaag opened 4 years ago

aabanaag commented 4 years ago

It is possible to use capacitor instead of Cordova for the archive process?

Got this error but I can't find a way to use capacitor instead of cordova

[ERROR] Ionic doesn't support using Cordova with @ionic/react projects.

        We encourage you to try ⚡️ Capacitor ⚡️ (https://ion.link/capacitor)

ionic prepare command ionic "cordova" "prepare" "--no-build" failed, error: exit status 1
pigeon-archive commented 4 years ago

Hi @aabanaag,

We are working on adding Capacitor support but it is currently not ready yet.

Please use a script step to do this.

aabanaag commented 4 years ago

Thank you for the update. But just to clarify so the step will be the same right? I still need to generate the build config then instead of ionic archive step I'll use the script to trigger ionic cap sync ios right?

aabanaag commented 4 years ago

If I simply trigger the command from the script I got this error

Running Ionic capacitor
> capacitor sync ios
[error] Capacitor could not find the web assets directory "/Users/vagrant/git/build".
    Please create it, and make sure it has an index.html file. You can change
    the path of this directory in capacitor.config.json.
    More info: https://capacitor.ionicframework.com/docs/basics/configuring-your-app
[ERROR] An error occurred while running subprocess capacitor.

        capacitor sync ios exited with exit code 1.

        Re-running this command with the --verbose flag may provide more information.

All I did was add a script step then add ionic cap sync ios command

pigeon-archive commented 4 years ago

Hi @aabanaag,

I'm not super familiar with Capacitor or Ionic but can you please confirm tat your web assets directory is in there?

aabanaag commented 4 years ago

Yes all of the web assets are there. I'll try to figure it out since there are output paths that the original ionic archive returns which is also a requirement for the next steps. Thanks!

mbecca commented 4 years ago

Yes all of the web assets are there. I'll try to figure it out since there are output paths that the original ionic archive returns which is also a requirement for the next steps. Thanks!

hello, did you find some alternative solution / workaround?

Regards,

M.

aabanaag commented 4 years ago

No, I ended up building it out separately instead.

mbecca commented 4 years ago

No, I ended up building it out separately instead.

Could you share with me how the complete command was? Thank you.

M.

mbecca commented 4 years ago

Hi @aabanaag,

We are working on adding Capacitor support but it is currently not ready yet.

Please use a script step to do this.

Hello, do you know when it could be available? Thank you.

M.

pigeon-archive commented 4 years ago

Hi @mbecca,

We don't have a fixed timeline as of right now. All I am able to say is "soon". Sorry!

aabanaag commented 4 years ago

hey @mbecca ,

For the steps, just setup your app not as an ionic project but just an iOS project, then on the script step add this

#!/usr/bin/env bash
# fail if any commands fails
set -e
# debug log
set -x

npm install -g npm@6.14.4
npm install
npm run build --verbose
npx cap sync ios

then for cocoapods, set the source path to ./ios also the BITRISE_PROJECT_PATH to ios/App/App.xcworkspace

aabanaag commented 4 years ago

Any update regarding the support for capacitor?

pigeon-archive commented 3 years ago

Still nothing unfortunately but it is being investigated.

SrinivasanTarget commented 3 years ago

@aabanaag Can you please share your bitrise.yml file here if possible?

@luna-kx any updates on the support?

pigeon-archive commented 3 years ago

Nothing yet unfortunately

marioshtika commented 3 years ago

Any update on this?

scottopolis commented 3 years ago

We are also looking for Capacitor support

SrinivasanTarget commented 3 years ago

@scottopolis I don't see it's worth waiting for an update here as I see they don't have any plans yet. We switched to use fastlane and it works pretty well for us.

scottopolis commented 3 years ago

@SrinivasanTarget do you mind sharing your code for the fastlane step?

s1rc commented 3 years ago

@SrinivasanTarget I'm also interested in how you configured your Fastlasne for Capacitor.

github-actions[bot] commented 3 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

fjaeger commented 3 years ago

Would be great to see official Capacitor support for Bitrise in combination with Ionic!

nbadiganti commented 3 years ago

Would be great to see support for capacitor bitrise builds.

benfavre commented 3 years ago

hello ?

MeMeMax commented 2 years ago

There is unfortunately pretty bad documentation. I can´t figure out in which order I have to add which steps for an Ionic Capacitor deployment. I don´t have a macbook and therefore I need to sign through a Workflow. But no chance with the current documentation.

bitrise-coresteps-bot commented 2 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

reynirf commented 2 years ago

This is still an important issue.

bitrise-coresteps-bot commented 2 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

marioshtika commented 2 years ago

still important to me

dserrano-netquest commented 9 months ago

still important, I do not want to pivot to another tool, please consider this topic a priority!!!

marioshtika commented 9 months ago

I know there is not a step yet for this on Bitrise, but they have created a sample project and a bitrise.yml file that will deploy it both on iOS and Android.

Take a look at this link https://github.com/bitrise-io/Bitrise-Capacitor-Sample/blob/main/bitrise.yml and build your way up from that

dserrano-netquest commented 9 months ago

thank you very much, and thank you for linking it here, maybe other lost souls find this thread before finding the bitrise custom .yml catalog

sindu commented 4 months ago

Hi guys, Exactly 4 years ago a qustion arose about using capacitor instead of Cordova for the archive process? You have on several occasions answered "it will be soon available"... Now, 4 (FOUR) years have passed and still nothing. Please, make this high priority!!!

You are supporting Ionic apps - many developers are trying to move from cordova to capacitor...

pigeon-archive commented 4 months ago

I no longer work at Bitrise. I am replying because I'll be unsubscribing to this thread after doing so.

@sindu It is unlikely you'll get a response from Bitrise from this thread alone. If you wish to rebump this feature request for them to build it, reach out to their developer support. They may or may not prioritize it (as I said I'm no longer affiliated with Bitrise). With that said, this repository is licensed under MIT and is open source. If you'd like to see support for this feature and depend on it as you say you do, I recommend reading the documentation and building it to contribute it for others to also benefit from. https://github.com/bitrise-steplib/steps-ionic-archive?tab=readme-ov-file#-contributing.

Best of luck.

mrsaleh commented 4 months ago

4 years and still this issue is open ? unbelievable.

dserrano-netquest commented 4 months ago

Hi, to the new people reaching, the link posted by marioshtika looks like a good place to start. I have been using a modified version for my specs at work.

Repost of the link: https://github.com/bitrise-io/Bitrise-Capacitor-Sample/blob/main/bitrise.yml