search

bitrise-steplib / steps-virtual-device-testing-for-android

MIT License
22 stars 23 forks source link

Max Timeout is set to 1800s when Firebase Test Lab allows for a maximum of 3600 #59

Closed geoff-powell closed 3 years ago

geoff-powell commented 4 years ago

This commit changed the max timeout from allowing 3600 to allow 1800. https://github.com/bitrise-steplib/steps-virtual-device-testing-for-android/commit/d117c3e4a3b9f1ff194aa7b1ed5e18328d24519b

Firebase test lab allows a larger max timeout for Virtual Devices (3600). https://cloud.google.com/sdk/gcloud/reference/beta/firebase/test/android/run#--timeout

Can you allow for 3600 to be set for the timeout, if the test is using virtual devices?

geoff-powell commented 4 years ago

I was able to use an older version (1.0.5) of this step and could successfully run our tests with 3600 set as the max timeout.

Roland-Bak commented 4 years ago

Hi there @gpowell13 , just wanted to let you know we are aware of this, and are investigating! ;) Will get back to you once there is progress :)

geoff-powell commented 4 years ago

Hi there @gpowell13 , just wanted to let you know we are aware of this, and are investigating! ;) Will get back to you once there is progress :)

Thanks for the quick response.

glureau-betclic commented 4 years ago

Hi there @Roland-Bak , Do you have some news on this topic?

Roland-Bak commented 4 years ago

Hey there @glureau-betclic, in fact I do! 🙂 Although no definite changes have been made, this is currently under estimation to be updated in the near future, and we'll get back to you once this implementation has been done 😉

glureau-betclic commented 4 years ago

I've created the PR, it's working fine on my side, but no test added. @Roland-Bak Tell me in the PR if you want me to add tests or anything.

glureau-betclic commented 4 years ago

This should be solved now, right?

https://github.com/bitrise-steplib/steps-virtual-device-testing-for-android/commit/02a4aaf447177ea130e0a1b335361d4d0d29c6d5

Release v1.1.2 : https://github.com/bitrise-steplib/steps-virtual-device-testing-for-android/releases/tag/1.1.2

ofalvai commented 3 years ago

Yes, this was solved in v1.1.2, I'm closing this issue. (let us know if you have other problems by opening a separate issue)