bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

Fix code smells #2703

Closed litepresence closed 1 year ago

litepresence commented 1 year ago

rewind is reserved prefix increment dropped_count, i, next_block_num for efficiency increment from method call fetch_by_number() could cause undefined behavior parenthesis added for explicit operator precedence
order of operations clarified max 1 nested break

abitmore commented 1 year ago

Proceeding with https://github.com/bitshares/bitshares-core/pull/2705.