search

bitshares / bitshares1-core

Software to run the old chain (before 2015-10-13). Code for current chain is https://github.com/bitshares/bitshares-core
https://bitshares.org/
The Unlicense
219 stars 174 forks source link

No Order history&K chart in BDR.AAPL : BitCNY market #1471

Closed abitmore closed 9 years ago

abitmore commented 9 years ago

https://bitsharestalk.org/index.php?topic=15132.0

vikramrajkumar commented 9 years ago

Possibly related: #1300

abitmore commented 9 years ago

I think it's better to record volumes of both assets rather than to record asset 0 only. Any thoughts?

vikramrajkumar commented 9 years ago

I agree.

abitmore commented 9 years ago

Please check pull request https://github.com/BitShares/bitshares/pull/1476

Note: returned structure of blockchain_market_price_history API changed, volume renamed to base_volume, and a new quote_volume added.

abitmore commented 9 years ago

I wonder if it's better to not rename volume in the API for backward compatibility.

vikramrajkumar commented 9 years ago

I think it is probably okay. I will review your PR when I get a chance.

abitmore commented 9 years ago

@vikramrajkumar need to back-port to older versions of market_engine, or not?

vikramrajkumar commented 9 years ago

Already done as part of: https://github.com/BitShares/bitshares/commit/739a858d6ff7a25674a4bdf0ceb40472097e3540