Add support for Liquidity Pools

bitshares / python-bitshares

Fully featured client-side library for the BitShares Blockchain - written entirely in python.

http://docs.pybitshares.com/

MIT License

162 stars 167 forks source link

Add support for Liquidity Pools #296

Closed christophersanborn closed 4 years ago

christophersanborn commented 4 years ago

BitShares 5.0.0 will add five new operations to create, manage, and use Liquidity Pools.

This PR brings support for these new operations to python-bitshares.

Progress:

[x] Operation objects in bitsharesbase.operations
[x] create_liquidity_pool() method
[x] delete_liquidity_pool() method
[x] deposit_into_liquidity_pool() method
[x] withdraw_from_liquidity_pool() method
[x] exchange_with_liquidity_pool() method

Note: Work in Progress — more commits to come.

See also: Uptick PR#43

christophersanborn commented 4 years ago

@xeroc — I believe this is done and ready for review.

christophersanborn commented 4 years ago

What's missing for me in general are unittests for the new operations in tests/test_transactions.py. I think you wrote some of those in the past. Either way, this is how I write them usually:

Agree of course with importance and utility of unit tests. Not sure I have time at the moment. Is this a show-stopper?

I haven't written any before, (slipped the voting ticket PR in without them ;-)), so I'll have to go over the steps and understand them better. Would like to punt this as a further TODO item if possible...