bitshares / python-bitshares

Fully featured client-side library for the BitShares Blockchain - written entirely in python.
http://docs.pybitshares.com/
MIT License
162 stars 167 forks source link

Block['id'] does not exist if string passed as 'block number' argument #321

Closed mellertson closed 1 year ago

mellertson commented 1 year ago

Issue

If you construct a Block object and pass a string as the block argument, the base class constructor BlockchainObject.__init__() does not set the 'id' attribute. This causes the Block constructor to behave differently when passing the block number argument as an integer VS a string.

In my case, this issue cases my BitShares blockchain explorer to miss caching some blocks.

mellertson commented 1 year ago

I accidentally opened this issue in this repo. But, should have opened it in python-graphenelib. So, I'm closing this issue.