PM-14597 Remove notification for declined approval requests

dseverns-livefront commented 2 weeks ago

(cherry picked from commit fd4a7c5716f188d049fa5dbd9c9df19896b44e31)

🎟️ Tracking

Cherry picking commit for hotfix from #4256

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 2 weeks ago

Checkmarx One – Scan Summary & Details – d048f3c4-0ea4-4ba2-befd-c2dc2fa8b429

New Issues

Issue	Source File / Package	Checkmarx Insight
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 29	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt: 94	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 240	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 251	Attack Vector
Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 262	Attack Vector
Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Use_of_Hardcoded_Password	/app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20	Attack Vector

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/hotfix-v2024.11.4@966a521). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/hotfix-v2024.11.4 #4287 +/- ## ============================================================ Coverage ? 88.95% ============================================================ Files ? 439 Lines ? 38139 Branches ? 5344 ============================================================ Hits ? 33925 Misses ? 2349 Partials ? 1865 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bitwarden / android