bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.57k stars 823 forks source link

PM-14851: Blank names should be considered null #4292

Closed david-livefront closed 2 weeks ago

david-livefront commented 2 weeks ago

🎟ī¸ Tracking

PM-14851

📔 Objective

This PR updates the SendVerificationEmailRequestJson to use a null name instead of an empty string.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 2 weeks ago

Logo Checkmarx One – Scan Summary & Details – 3570c58d-dd3c-4656-ad49-603aa7a4adfd

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26
david-livefront commented 2 weeks ago

Thanks @dseverns-livefront

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.01%. Comparing base (9a5aa21) to head (aef4c36). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4292 +/- ## ======================================= Coverage 89.01% 89.01% ======================================= Files 453 453 Lines 39064 39064 Branches 5481 5482 +1 ======================================= Hits 34771 34771 Misses 2369 2369 Partials 1924 1924 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.