[PM-13831] Add copy button identity and note fields

aj-rosado commented 2 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13831

📔 Objective

Adding easy access copy button for the identity fields and notes fields to match other clients.

📸 Screenshots

View identity cipher screen

View login cipher screen

View card cipher screen

View secure note cipher screen

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 2 weeks ago

Checkmarx One – Scan Summary & Details – cb3c8644-f4d3-4c92-a224-e0f06b534809

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 93.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (2d15c48) to head (0cf3db3). Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...warden/ui/vault/feature/item/VaultItemViewModel.kt	82.19%	0 Missing and 13 partials :warning:
.../ui/vault/feature/item/VaultItemIdentityContent.kt	98.50%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4302 +/- ## ======================================== Coverage 89.00% 89.00% ======================================== Files 452 453 +1 Lines 38997 39141 +144 Branches 5484 5509 +25 ======================================== + Hits 34710 34839 +129 Misses 2377 2377 - Partials 1910 1925 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

aj-rosado commented 2 weeks ago

This PR is missing some tests, working on them

bitwarden / android