bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.57k stars 823 forks source link

PM-15022 Auto login when user completes a YubiKey login trigger. #4368

Closed dseverns-livefront closed 1 week ago

dseverns-livefront commented 1 week ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-15022

📔 Objective

Required for any UI changes; delete if not applicable. Use fixed width images for better display. -->

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Details – bf8e4ee6-26be-40a8-83c4-d1e7d1ee9d07

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.03%. Comparing base (b19e7e1) to head (a9ce511). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4368 +/- ## ======================================= Coverage 89.03% 89.03% ======================================= Files 451 451 Lines 39135 39138 +3 Branches 5523 5523 ======================================= + Hits 34842 34845 +3 Misses 2368 2368 Partials 1925 1925 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: