PM-15147 - Design Audit - Master Password Guidance Screen

[phil-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15147

📔 Objective

• Align Text: Center-align the title and subtitle text across relevant components.
• Design Updates: Update the content block styling to match the Figma designs for V3.
• Background Changes: Remove the blue background from the "What makes a password strong?" block.
• Registration Screen Adjustments: Remove the blue content background from the CompleteRegistrationScreen where the MasterPasswordGuidanceScreen is launched. This follows iOS design changes. Retain the border color to minimize deviations.
• Action Card Enhancement: Modify BitwardenActionCard to include an optional dismiss action, supporting scenarios like the MasterPasswordGuidanceScreen where no dismiss action is required.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – eea1bb35-3c8f-4410-a6e4-8776cffd948c

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 98.73418% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (cce9bef) to head (47c5e86).

Files with missing lines	Patch %	Lines
...erpasswordguidance/MasterPasswordGuidanceScreen.kt	98.68%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4383 +/- ## ======================================= Coverage 89.01% 89.01% ======================================= Files 451 451 Lines 39129 39142 +13 Branches 5534 5534 ======================================= + Hits 34831 34844 +13 Misses 2370 2370 Partials 1928 1928 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests