search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-479 | Fix magic links section lifecycle when locking/unlocking API keys #641

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Ticket

Description

Magic links section was broken when unlocking/locking API keys.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 34.07%. Comparing base (b66156e) to head (3fbe375).

Files Patch % Lines
...ings/SettingsComponents/MagicLinksSection.razor.cs 0.00% 26 Missing :warning:
...uallyGeneratedAuthenticationTokensSection.razor.cs 0.00% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #641 +/- ## ========================================== - Coverage 34.11% 34.07% -0.05% ========================================== Files 534 536 +2 Lines 27555 27592 +37 Branches 807 815 +8 ========================================== Hits 9401 9401 - Misses 18023 18060 +37 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonashendrickx commented 2 months ago

@abergs this one had a merge conflict