search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

Fix Open API documentation spawning multiple ApiKey/ApiSecret fields #653

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Description

ApiKey and ApiSecret fields had 2 to more entries when viewing the API documentation at /swagger/index.html.

Shape

Removed .WithOpenApi() from grouped endpoint builders, and moved it to individually to prevent the same bug happening.

Screenshots

image

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.51%. Comparing base (b66156e) to head (1890f65). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #653 +/- ## ========================================== - Coverage 34.11% 33.51% -0.61% ========================================== Files 534 556 +22 Lines 27555 29644 +2089 Branches 807 834 +27 ========================================== + Hits 9401 9935 +534 - Misses 18023 19577 +1554 - Partials 131 132 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.