search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-553 | Pressing ESC should close modals #678

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 1 month ago

Ticket

Description

Pressing 'ESC' should close modals when they are open.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.81%. Comparing base (62926dc) to head (1eba326). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #678 +/- ## ======================================= Coverage 34.81% 34.81% ======================================= Files 566 566 Lines 30985 30985 Branches 926 926 ======================================= Hits 10788 10788 Misses 20055 20055 Partials 142 142 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.