bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-558 | Refactor application creation & avoid enumeration #687

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 1 month ago

Ticket

Description

Shape

Screenshots

image

image

image

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 16.30435% with 77 lines in your changes missing coverage. Please review.

Project coverage is 34.88%. Comparing base (c1bb7c5) to head (69b176b).

Files Patch % Lines
...ents/Pages/Organization/CreateApplication.razor.cs 0.00% 66 Missing :warning:
...ponents/Pages/Organization/CreateApplication.razor 0.00% 3 Missing :warning:
src/AdminConsole/Middleware/CurrentContext.cs 0.00% 2 Missing :warning:
...Common/Services/IdGeneration/IdGeneratorFactory.cs 33.33% 1 Missing and 1 partial :warning:
src/Service/SharedManagementService.cs 75.00% 1 Missing and 1 partial :warning:
src/AdminConsole/Components/Shared/Panel.razor 50.00% 0 Missing and 1 partial :warning:
...wordlessManagement/PasswordlessManagementClient.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #687 +/- ## ========================================== - Coverage 34.88% 34.88% -0.01% ========================================== Files 566 567 +1 Lines 30995 30961 -34 Branches 933 931 -2 ========================================== - Hits 10814 10802 -12 + Misses 20038 20017 -21 + Partials 143 142 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abergs commented 1 month ago

I don't think this is an initiative we want to merge, will need to review at a later date. Please hold this.