search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

Improve integration tests performance #689

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 1 month ago

Description

Significantly reduces the resources required to run the integration tests as it reuses the Microsoft SQL Server test container.

If the tests are properly written, we should not see any issues. In case we do need a unique instance, we can just use a different collection identifier.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.88%. Comparing base (c1bb7c5) to head (0405932). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #689 +/- ## ======================================= Coverage 34.88% 34.88% ======================================= Files 566 566 Lines 30995 30995 Branches 933 933 ======================================= Hits 10814 10814 Misses 20038 20038 Partials 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tyrrrz commented 1 month ago

In case we do need a unique instance, we can just use a different collection identifier.

We can also re-use the same MSSQL instance but access different database instances.