search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-467 | Fix accessibility issues on signup page #691

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 1 month ago

Ticket

Description

Fixes the following issues:

<img class="w-10" src="/img/tag1.svg">

<a href="">

<html lang="en" class="h-full">

Shape

Screenshots

image

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 34.88%. Comparing base (c654950) to head (08db983). Report is 3 commits behind head on main.

Files Patch % Lines
...dminConsole/Components/Shared/Icons/LogoFull.razor 0.00% 5 Missing :warning:
...inConsole/Components/Shared/Icons/LogoMobile.razor 0.00% 5 Missing :warning:
...dminConsole/Components/Shared/Links/LinkHome.razor 0.00% 5 Missing :warning:
src/AdminConsole/Components/Shared/Page.razor 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #691 +/- ## ========================================== - Coverage 34.89% 34.88% -0.01% ========================================== Files 566 566 Lines 31001 31009 +8 Branches 934 936 +2 ========================================== + Hits 10818 10819 +1 - Misses 20039 20045 +6 - Partials 144 145 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.