search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

Do not execute event logging middleware on undefined endpoints #694

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 1 month ago

Description

The middleware shouldn't be executing on undefined endpoints, given there's nothing to log.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.88%. Comparing base (3591d04) to head (5aaf00e). Report is 2 commits behind head on main.

Files Patch % Lines
src/Api/Middleware/PathValidation.cs 88.23% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #694 +/- ## ========================================== - Coverage 34.89% 34.88% -0.01% ========================================== Files 566 567 +1 Lines 31007 31010 +3 Branches 936 936 ========================================== - Hits 10819 10818 -1 - Misses 20043 20046 +3 - Partials 145 146 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.