search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-536 | Add support for `AuthenticatorDisplayName` #713

Open Tyrrrz opened 4 weeks ago

Tyrrrz commented 4 weeks ago

Waiting on: https://github.com/bitwarden/passwordless-dotnet/pull/152

Tyrrrz commented 3 weeks ago

@abergs yes, correct

Tyrrrz commented 3 weeks ago

This needs a new release of Passwordless.NET and a package update to resolve missing references

Tyrrrz commented 2 weeks ago

Added migrations and updated the Passwordless.NET SDK version to 2.1.0-beta.3 which is pending approval here: https://github.com/bitwarden/passwordless-devops/actions/runs/10775849985

Once that package is released, this PR should technically be good to merge. Would still need to run some smoke tests for good measure, however.

Tyrrrz commented 2 weeks ago

Should be ready

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 52.53785% with 533 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (3cfa4f5) to head (91e50fc).

Files with missing lines Patch % Lines
...0240909154138_AuthenticatorDisplayName.Designer.cs 0.00% 459 Missing :warning:
src/Service/Fido2Service.cs 72.91% 24 Missing and 2 partials :warning:
...dminConsole/Components/Shared/Credentials.razor.cs 0.00% 25 Missing :warning:
.../Sqlite/20240909154138_AuthenticatorDisplayName.cs 0.00% 10 Missing :warning:
...s/Mssql/20240909154123_AuthenticatorDisplayName.cs 60.00% 4 Missing :warning:
...vice/Migrations/Mssql/MsSqlContextModelSnapshot.cs 0.00% 4 Missing :warning:
...ce/Migrations/Sqlite/SqliteContextModelSnapshot.cs 0.00% 4 Missing :warning:
src/AdminConsole/Helpers/StringExtensions.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #713 +/- ## ========================================== + Coverage 35.15% 35.56% +0.40% ========================================== Files 579 584 +5 Lines 31252 32202 +950 Branches 949 950 +1 ========================================== + Hits 10988 11452 +464 - Misses 20119 20603 +484 - Partials 145 147 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.