bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

Images in QA or `main` should not have `latest` tag. #724

Closed jonashendrickx closed 3 weeks ago

jonashendrickx commented 3 weeks ago

Ticket

Description

When we pull Docker images, we would expect to have latest always reflect a stable release or production release by default. Now, the latest tag seems to pull any image that is in the main branch or in QA testing.

I've changed the behavior to below, so people can still continue testing the latest qa or dev build separately. While the latest production release will carry the tags latest and stable in addition to their respective build numbers.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.15%. Comparing base (2d9dd79) to head (b00c5eb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #724 +/- ## ======================================= Coverage 35.15% 35.15% ======================================= Files 573 573 Lines 31174 31174 Branches 931 931 ======================================= Hits 10960 10960 Misses 20068 20068 Partials 146 146 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.