search

bitwiseshiftleft / sjcl

Stanford Javascript Crypto Library
http://bitwiseshiftleft.github.com/sjcl/
Other
7.18k stars 986 forks source link

JSDoc for PBKDF2 states incorrect default for count / number of iterations #395

Open cpupower opened 5 years ago

cpupower commented 5 years ago

I think the documentation for PBKDF2 states an incorrect number of iterations for the default case. In the JSDoc it states a default number of 1,000 iterations, however in the code it actually uses 10,000 iterations if count is falsy.

https://github.com/bitwiseshiftleft/sjcl/blob/2a6ed4a22449334de2dd9b4e960af679e0e87303/core/pbkdf2.js#L16-L23