search

bitwiseworks / qtwebengine-chromium-os2

Port of Chromium and related tools to OS/2
9 stars 2 forks source link

Apply OS/2 patches to in-house SQLite #17

Closed dmik closed 4 years ago

dmik commented 4 years ago

As mentioned in https://github.com/bitwiseworks/qtwebengine-os2/issues/6#issuecomment-679167319:

SQLite problems are there because Chromium uses its own version (third_party/sqlite) and there is no option to use the system library because they claim to have patches that are never going to be accepted upstream. So the only solution here is to apply OS/2 patches there. Will create a ticket for that.

We should drag in significant patches from https://github.com/bitwiseworks/sqlite-os2.

dmik commented 4 years ago

I've applied all the patches but for some reason it triggered building all the 10.000 of compilation units, sigh :(

dmik commented 4 years ago

The above fixes the problem and now the Chromium version of SQLite works well. This didn't fix the application problem (see the other ticket from the description) but at least Chromium can create the Cookie database now.

Note that for some reason the amalgamated version of SQLite in Chromium was outdated compared to the normal sources which looked more recent (see f394894 for details -- all non OS/2 related changes are of that matter). Looks like the Chromium guys didn't reamalgamate (despite their own policy described in README.chromium) since they updated the normal SQLite sources for the last time. I really hope it won't break anything (and if it does, this is fixed in newer Chromium drops used in newer Qt).